Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sending entity to Fluentbit via cloudwatch agent server #262

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Add support for sending entity to Fluentbit via cloudwatch agent server #262

merged 5 commits into from
Oct 28, 2024

Conversation

lisguo
Copy link
Contributor

@lisguo lisguo commented Oct 28, 2024

Issue #, if available: N/A

Description of changes:

  • Opens a port on cloudwatch agent pod if application signals is defined in the config on 4311. This port is used to talk to fluentbit to retrieve service name from an instrumented application
  • Populates the Service name as Workload name if service.name attribute does not exist
  • Add K8s ReplicaSet to be used as a workload name
  • Populate ServiceNameSource with Instrumentation if the application is instrumented, or default to K8sWorkload

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nathalapooja and others added 5 commits September 23, 2024 10:15
@nathalapooja
added agent server port as default port on CW agent (#234)
1cebeeb
@zhihonl
Attach service name source as resource attribute to operator (#235)
1cc80a7 
* Add service name source for instrumentation and workload

* Change service name source attribute naming

* Fix unit tests for pod mutators

* Simplify service name source determination

* Fix incorrect refactor of source constants
@zhihonl
Use replicaset name as part of service name fallback (#249)
72ea08f 
* Use replicaset name as part of service name fallback

* Add chooseServiceName unit test

* Change import statement ordering
@nathalapooja
Fix service name source being added multiple times for multiple injec…
79a21d9 
…tions (#254)

* added fix to not override the service name source for multiple auto-inject
@lisguo
Create cwa-server port when application signals is enabled
99509e4
@lisguo lisguo merged commit ca98f33 into main Oct 28, 2024
8 checks passed
@lisguo lisguo deleted the entity branch October 28, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathalapooja nathalapooja nathalapooja approved these changes

@zhihonl zhihonl zhihonl approved these changes

@jefchien jefchien Awaiting requested review from jefchien

@sky333999 sky333999 Awaiting requested review from sky333999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lisguo @nathalapooja @zhihonl