Change E2E Testing Resource Repo from OTEL to Application Framework #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| TEST_ACCOUNT: ${{ secrets.APP_SIGNALS_E2E_TEST_ACCOUNT }} | ||
| TEST_ACCOUNT: ${{ secrets.APP_SIGNALS_E2E_TEST_ACCOUNT_ID }} |
There was a problem hiding this comment.
Is there a reason why we needed to change the secret here?
There was a problem hiding this comment.
Gave CWAgent team the same secret names as the CloudWatch repo, so they updated it with new secrets. I think this might be better though for consistency with the CloudWatch repo.
harrryr
force-pushed
the
get-e2e-testing-resource-from-application-framework-repo
branch
2 times, most recently
from
e46ccc5
to
b04aac8
Compare
sky333999
force-pushed
the
get-e2e-testing-resource-from-application-framework-repo
branch
from
b04aac8
to
f293f67
Compare
sky333999
approved these changes
Mar 4, 2024
sky333999
deleted the
get-e2e-testing-resource-from-application-framework-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Testing resources for E2E Testing has been moved to https://github.com/aws-observability/aws-application-signals-test-framework, need to update e2e testing workflow to retrieve from that repo.
Test run: https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/8100693464
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.