Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change E2E Testing Resource Repo from OTEL to Application Framework #101

Merged

Conversation

harrryr
Copy link
Collaborator

@harrryr harrryr commented Feb 28, 2024

Issue #, if available:
Testing resources for E2E Testing has been moved to https://github.com/aws-observability/aws-application-signals-test-framework, need to update e2e testing workflow to retrieve from that repo.

Test run: https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/8100693464

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

TEST_ACCOUNT: ${{ secrets.APP_SIGNALS_E2E_TEST_ACCOUNT }}
TEST_ACCOUNT: ${{ secrets.APP_SIGNALS_E2E_TEST_ACCOUNT_ID }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we needed to change the secret here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave CWAgent team the same secret names as the CloudWatch repo, so they updated it with new secrets. I think this might be better though for consistency with the CloudWatch repo.

.github/workflows/appsignals-e2e-test.yml Show resolved Hide resolved
.github/workflows/appsignals-e2e-test.yml Outdated Show resolved Hide resolved
.github/workflows/appsignals-e2e-test.yml Show resolved Hide resolved
@harrryr harrryr force-pushed the get-e2e-testing-resource-from-application-framework-repo branch 2 times, most recently from e46ccc5 to b04aac8 Compare February 29, 2024 21:31
Copy link
Collaborator

@majanjua-amzn majanjua-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sky333999 sky333999 force-pushed the get-e2e-testing-resource-from-application-framework-repo branch from b04aac8 to f293f67 Compare March 4, 2024 23:16
@sky333999 sky333999 merged commit abf75ba into main Mar 4, 2024
4 checks passed
@sky333999 sky333999 deleted the get-e2e-testing-resource-from-application-framework-repo branch March 4, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants