Fixes incorrect event being published when the meeting is ended normally. #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensmi-amazon
previously approved these changes
Dec 12, 2024
|
Same comments as iOS |
pracheth
previously approved these changes
Dec 12, 2024
ziyiz-amzn
reviewed
Jan 15, 2025
georgezy-amzn
previously approved these changes
Feb 7, 2025
dylonChime
force-pushed
the
fix-meeting-status-event
branch
from
8603554 to
1216897
Compare
dylonChime
dismissed stale reviews from pracheth, hensmi-amazon, and georgezy-amzn
via
5a3232d
dylonChime
force-pushed
the
fix-meeting-status-event
branch
2 times, most recently
from
5a3232d to
cc83d34
Compare
ziyiz-amzn
reviewed
Feb 11, 2025
.../java/com/amazonaws/services/chime/sdk/meetings/internal/audio/DefaultAudioClientObserver.kt
Outdated
Show resolved
Hide resolved
dylonChime
force-pushed
the
fix-meeting-status-event
branch
3 times, most recently
from
94307e7 to
ed61433
Compare
ziyiz-amzn
previously approved these changes
Feb 11, 2025
dylonChime
force-pushed
the
fix-meeting-status-event
branch
3 times, most recently
from
a89331a to
427b402
Compare
georgezy-amzn
previously approved these changes
Feb 13, 2025
dylonChime
force-pushed
the
fix-meeting-status-event
branch
from
427b402 to
1fb31ee
Compare
georgezy-amzn
approved these changes
Feb 13, 2025
ziyiz-amzn
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Description
Fixes incorrect event being published when the meeting is ended normally.
Issue #, if available
Type of change
🧪 How Has This Been Tested?
describe the tests that you ran to verify your changes, any relevant details for your test configuration
Unit test coverage
Additional Manual Test
📱 Screenshots, if available
provide screenshots/video record if there's a UI change in demo app
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.