Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: bring your own UserPool #159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bogdankatishev
Copy link

Description of changes:
Added new CfnParameter: ExistingCognitoPoolId:

  • If empty string is passed (""): it will create a DLTUserPool Resource.
  • If an Cognito PoolId is passed: it will skip the creation of the DLTUserPool Resource and it will use your own given UserPool.

Also updated the snapshots and tests of the templates to includes these changes ⬆️

Checklist

  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

A question towards the people of AWS/maintainers: should I include a Condition to skip the creation of the default admin user when giving an existing Cognito PoolId?

@kamyarz-aws
Copy link
Member

Thank you for this contribution. We will review this feature with our product team and if approved internally we will include this in one of our future releases with your name as a contributor.

@kamyarz-aws
Copy link
Member

Hi @bogdankatishev, can you please gives some more information on why do you want to include this feature. I understand the logic but I also want to know more how different users might use this feature.

@bogdankatishev
Copy link
Author

Hello @kamyarz-aws, I added this feature because we already had an existing Cognito UserPool within our AWS account where all the existing system accounts/etc... reside. And so we wanted to avoid creating a new UserPool, with only 1 default system user in it.

@bogdankatishev
Copy link
Author

Hello, any updates on this? @kamyarz-aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants