Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New serverless pattern - AWS Secrets Manager to CloudWatch Events to SNS (Terraform) #1722

Conversation

MakendranG
Copy link
Contributor

@MakendranG MakendranG commented Oct 10, 2023

Issue #, if available: #1723

Description of changes:

This pattern contains a terraform template to detect and notify on Amazon Secrets Manager Secret Key Creation, Updation and Deletion using Amazon CloudWatch event and Amazon SNS.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor Author

@MakendranG MakendranG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the pattern file.

Copy link
Contributor Author

@MakendranG MakendranG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the file

@MakendranG
Copy link
Contributor Author

The example-pattern file have all the parameters. Still failing the checks. Kindly update which parameter is getting failed.

Copy link
Contributor Author

@MakendranG MakendranG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the comma in the pattern file

@MakendranG
Copy link
Contributor Author

Hello @mavi888

Thanks for the update.
As per the request, I have updated the pattern file. Automated system have picked the pattern and validated. Now it is waiting for approval. Kindly do the needful.

@mavi888
Copy link
Contributor

mavi888 commented Oct 23, 2023

I just tested this pattern and it doesnt work.
When looking at the rule created there is no target defined for it.

Added target to the event rule
@MakendranG MakendranG changed the title New serverless pattern - AWS Secrets Manager to CloudWatch Events to Lambda to SNS (Terraform) New serverless pattern - AWS Secrets Manager to CloudWatch Events to SNS (Terraform) Oct 24, 2023
@MakendranG
Copy link
Contributor Author

I just tested this pattern and it doesnt work. When looking at the rule created there is no target defined for it.

Have modified the terraform file with the target.

@MakendranG
Copy link
Contributor Author

Hello @mavi888

Thanks for the update.
As per the request, I have updated the terraform file. Automated system have picked the pattern and validated. Now it is waiting for approval. Kindly do the needful.

@mavi888
Copy link
Contributor

mavi888 commented Oct 30, 2023

The pattern doesnt work.
Please test it before submiting it again

Copy link
Contributor Author

@MakendranG MakendranG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the necessary changes

Copy link
Contributor Author

@MakendranG MakendranG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified pattern file

Copy link
Contributor Author

@MakendranG MakendranG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified pattern file

@mavi888
Copy link
Contributor

mavi888 commented Nov 6, 2023

This pattern still doesnt work. I will close it and please open it when you are sure you test it out, granted all the permissions needed and everything is polished.

@mavi888 mavi888 closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants