Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor users service from go to python #596

Open
wants to merge 101 commits into
base: master
Choose a base branch
from

Conversation

Adibuer-lab
Copy link
Contributor

@Adibuer-lab Adibuer-lab commented Jun 5, 2024

Issue #, if available:
#13
Description of changes:
Refactor users service from go to python

  1. New users service created under users folder with old go based service moved to users-old for reference during PR
  2. Changed from in-memory storage of users to using dynamodb
  3. Updated cloudformation templates to deploy users dynamodb table with appropriate permissions for users service to access table
  4. Added custom resource and lambda function to load users table with shoppers during deployment of retail demo store
  5. append unique string to cloudfront request policies

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):
Integration testing using testing scripts and tested by deploying into aws account

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Adibuer-lab
Copy link
Contributor Author

@gfaires ready for review again. Sorry for wait, wanted to make the auto-select shopper and select shopper based on persona and age faster, but pynamodb didn't support sort key queries on GSI's. Ended up reverting to flask, and base dynamodb api's. but now things are much faster, for example testing script which used to run through all endpoints in 3 seconds does it in 0.8 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants