-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor users service from go to python #596
Open
Adibuer-lab
wants to merge
101
commits into
aws-samples:master
Choose a base branch
from
Adibuer-lab:refactor-users-service-from-go-to-python
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor users service from go to python #596
Adibuer-lab
wants to merge
101
commits into
aws-samples:master
from
Adibuer-lab:refactor-users-service-from-go-to-python
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gfaires ready for review again. Sorry for wait, wanted to make the auto-select shopper and select shopper based on persona and age faster, but pynamodb didn't support sort key queries on GSI's. Ended up reverting to flask, and base dynamodb api's. but now things are much faster, for example testing script which used to run through all endpoints in 3 seconds does it in 0.8 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#13
Description of changes:
Refactor users service from go to python
Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):
Integration testing using testing scripts and tested by deploying into aws account
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.