Skip to content

Commit

Permalink
fix: previous commits accidentally ignored lib/ files and other impor…
Browse files Browse the repository at this point in the history
…tant files

.projenrc.ts ignores lib dir, but lib dir is used differently in this project. So libdir was set to
out/. This allowed lib/ to be included again.

BREAKING CHANGE: Previous commit fails to build
  • Loading branch information
flamingquaks committed Oct 28, 2024
1 parent b25cad9 commit aa13981
Show file tree
Hide file tree
Showing 18 changed files with 13,866 additions and 10 deletions.
5 changes: 4 additions & 1 deletion .gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 12 additions & 6 deletions .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const project = new awscdk.AwsCdkTypeScriptApp({
cdkVersion: '2.164.1',
srcdir: '.',
outdir: '.',
libdir: 'out/',
defaultReleaseBranch: 'main',
name: 'generative-ai-newsletter-app',
projenrcTs: true,
Expand All @@ -15,6 +16,9 @@ const project = new awscdk.AwsCdkTypeScriptApp({
'misc/',
'.DS_Store',
'eslint-results.sarif',
'**/*.d.ts',
'lib/**/*.js',
'lib/api/functions/out/',
],
appEntrypoint: 'bin/genai-newsletter-app.ts',
bin: {
Expand Down Expand Up @@ -87,14 +91,16 @@ const project = new awscdk.AwsCdkTypeScriptApp({
exclude: ['node_modules', 'lib/user-interface/genai-newsletter-ui/*'],
},
});
// projen auto adds lib/, but this project is laid out differently and needs to include lib/
project.gitignore.removePatterns('lib');

project.addFields({
"config": {
"commitizen": {
"path": "./node_modules/cz-conventional-changelog"
}
}
})
config: {
commitizen: {
path: './node_modules/cz-conventional-changelog',
},
},
});

// Existing tasks
project.tasks.addTask('config', {
Expand Down
6 changes: 6 additions & 0 deletions lib/user-interface/genai-newsletter-ui/.env.local
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Replace with your configuration after you deploy
AWS_PROJECT_REGION=
AWS_COGNITO_REGION=
AWS_USER_POOLS_ID=
AWS_USER_POOLS_WEB_CLIENT_ID=
VITE_CLOUDFRONT_ENDPOINT="https://d2s5fsx54v0gnu.cloudfront.net"
221 changes: 221 additions & 0 deletions lib/user-interface/genai-newsletter-ui/.eslintrc.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions lib/user-interface/genai-newsletter-ui/.gitattributes

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 41 additions & 0 deletions lib/user-interface/genai-newsletter-ui/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions lib/user-interface/genai-newsletter-ui/.npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit aa13981

Please sign in to comment.