Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Added a new lab 'Mountpoint for S3' #1176

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

rchandra20
Copy link

What this PR does / why we need it:

EKS Workshop can benefit greatly from a module that showcases the use of Mountpoint for S3. This content is placed under the Fundamentals/Storage exercises.

Which issue(s) this PR fixes: Fixes #843

Quality checks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Rishiraj Chandra and others added 25 commits August 23, 2024 15:44
…s to be copied from retail store image into assets container
…access mountpoint by altering PV permissions
add mountpoint for s3 workshop content - contains placeholder content to change assets at a later date
updated revision that includes feedback from offline review
updated assets-s3.webp to reflect S3 architecture diagram instead of EFS architecture diagram
Updated workshop flow to simplify a command
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit 08d93f9
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/672a7484a84e260008e2bc1d
😎 Deploy Preview https://deploy-preview-1176--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

heinrichse
heinrichse previously approved these changes Nov 4, 2024
Copy link
Contributor

@heinrichse heinrichse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved PR

heinrichse
heinrichse previously approved these changes Nov 4, 2024
heinrichse
heinrichse previously approved these changes Nov 5, 2024
Copy link
Contributor

@heinrichse heinrichse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved

Copy link
Contributor

@pengc99 pengc99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this in rchandra20's repo already - this content is ready to be merged from my end. Would appreciate a second look.

Copy link
Contributor

@niallthomson niallthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, noted some changes I think we should make


First inspect the `s3pvclaim.yaml` file to see the parameters in the file and the claim:

```file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of displaying the file with comments please use the component we have specifically for explaining YAML files https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/ui_components.md#yaml-file

assets-9fbbbcd6f-lb46c 1/1 Running 0 6m55s
```

Finally, let's take a look at our final deployment with the Mountpoint for Amazon S3 CSI driver:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its necessary to show the whole deployment, its a lot of text with no explanation.


We can start by describing the Deployment to take a look at its initial volume configuration:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can shorten the amount of information here, its a lot not related to the volumes etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Mountpoint for Amazon S3 Module to the Fundamentals/Storage exercises
4 participants