Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit hooks #268

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Update pre-commit hooks #268

merged 2 commits into from
Dec 5, 2024

Conversation

rezabekf
Copy link
Contributor

@rezabekf rezabekf commented Dec 5, 2024

What does this PR do and why?

This PR updates pre-commit hooks to the latest releases. You may notice lot of changes, however these are mainly down to formatting from rain hook. Changes to notice:

  • the GitHub actions was installing requirements.txt which was completely unnecessary, we only need pre-commit for our action.
  • suppress cfn-lint check "W1011 Use dynamic references over parameters for secrets"
  • bump deprecated python 3.8 runtime (the runtime update in content will be addressed in subsequent PR)
  • remove Fn::Sub from parameter import
  • fix formatting for !Select...!GetAzs

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rezabekf rezabekf requested a review from a team as a code owner December 5, 2024 10:44
@rezabekf rezabekf merged commit 2c661d6 into main Dec 5, 2024
2 checks passed
@rezabekf rezabekf deleted the rezabekf/update-pre-commit branch December 5, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants