-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fixes #262
bug fixes #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the contribution. I have provided a feedback. Particularly changes to React MD are breaking generation of code blocks. I would suggest to install preview_build tool to verify the markdown generates correctly. I have suggested the correct code to fix React MDs code block generation issues.
Thank you for updating the out of date screenshot. Going forward, we should probably remove the screenshot of the documentation/console altogether to avoid this happening in the future when there is an update to the UI. Perhaps link to official documentation is the better approach.
Lastly, the addition of extra content to intrinsic function REF vs. SUB, I have left the inline comment. Feel free to reach out directly to discuss this as I would like to understand if the customers faced any sort of confusion or further clarification is required.
Cheers, Franco
Updated with the changes suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT 👍
What does this PR do and why?
This PR address some of the issues/challenges faced by the customer during a recent immersion day led by a Solution Architect.
Issue #, if available
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
make version part=<major|minor|patch>
?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.