-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Guardrails for Amazon Bedrock #520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/guardrails
… into feature/guardrails
memo: We don't have backward compatibility due to the regional change of document bucket. If user include this PR, existing bucket likely be lost. Consider to re-create this PR to merge v2 branch, not v1. |
statefb
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!コメントがやや多くて恐縮ですが、お手隙の際ご対応よろしくお願いします!
サマリ:
BE
- 「ガードレール削除」の削除
- Decimalではなく floatの利用
- is_guardrail_enabledの削除
- get_guardrailの削除
FE
- Expandableではなくグルーピング
- 説明文章
amazon-codecatalyst
bot
requested review from
wadabee and
Yukinobu-Mine
as code owners
September 30, 2024 04:21
statefb
force-pushed
the
feature/guardrails
branch
from
October 4, 2024 05:07
2896226
to
bec977f
Compare
Integrate compose_args_for_converse_api
Yukinobu-Mine
approved these changes
Oct 10, 2024
statefb
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#289
Description of changes:
Implement content filters and contextual grounding checks for Guardrails for Amazon Bedrock.
It will delete the S3bucket that stores the documents you have been using until now and re-create it in BedrockRegion.Because Knowledge base and Guardrails must run in the same region.
Parameters of Guardrails are stored in the Dynamodb.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.