Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AWS Pytorch channel in examples #453

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

junpuf
Copy link
Contributor

@junpuf junpuf commented Oct 7, 2024

Issue #, if available:
#444

Description of changes:
The AWS PyTorch Conda channel is being deprecated, future development will be stopped, so removing the usage of it.


Testing

Test infra is 2 p4d using pcluster with fsx and slurm built using DLAMI (the same AMI used by HyperPod AMI).

10.FSDP

  • Passed test
  • Below environment variables are no longer required in newer aws-ofi-nccl versions.
export FI_EFA_USE_DEVICE_RDMA=1 # use for p4d
export FI_EFA_FORK_SAFE=1
  • Fixed README.md

16.pytorch-cpu-ddp

  • Passed test
  • updated conda env creation process

17.SM-modelparallelv2

For 17.SM-modelparallelv2, it seems pytorch="2.2.0=sm_py3.10_cuda12.1_cudnn8.9.5_nccl_pt_2.2_tsm_2.3_cuda12.1_0 declared dependency on aws-ofi-nccl >=1.7.1,<2.0 (probably due to copying the build recipe from aws conda channel). Because of this, i made a workaround by supplying the 2 binaries needed for this pytorch package.

Could not solve for environment specs
The following package could not be installed
└─ pytorch ==2.2.0 sm_py3.10_cuda12.1_cudnn8.9.5_nccl_pt_2.2_tsm_2.3_cuda12.1_0 is not installable because it requires
   └─ aws-ofi-nccl >=1.7.1,<2.0 , which does not exist (perhaps a missing channel).

Workaround included 2 binaries (details below) required in a new bin directory inside the example directory.

# dependency package for pytorch ==2.2.0 sm_py3.10_cuda12.1_cudnn8.9.5_nccl_pt_2.2_tsm_2.3_cuda12.1_0
aws-ofi-nccl-1.7.4-aws_0.tar.bz2 
# dependency package for aws-ofi-nccl-1.7.4-aws_0.tar.bz2 
hwloc-2.9.2-h2bc3f7f_0.tar.bz2

20.FSDP-Mamba

Simply removed commented lines that referenced the AWS PyTorch conda channel, no test necessary


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@junpuf junpuf changed the title Remove AWS Pytorch channel in FSDP example Remove AWS Pytorch channel in examples Oct 7, 2024
Copy link
Contributor

@mhuguesaws mhuguesaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lef comments

3.test_cases/10.FSDP/1.distributed-training.sbatch Outdated Show resolved Hide resolved
3.test_cases/10.FSDP/README.md Outdated Show resolved Hide resolved
@mhuguesaws mhuguesaws marked this pull request as draft October 8, 2024 01:19
@sean-smith
Copy link
Contributor

@junpuf why is this marked as a draft? can we mark it ready for review

@junpuf junpuf marked this pull request as ready for review October 8, 2024 20:20
Copy link
Contributor

@sean-smith sean-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future let's remove the aws-ofi-nccl and hwloc dependencies.

@sean-smith sean-smith merged commit 32fb5ae into aws-samples:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants