-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature scheduling strikes back #564
Open
iakov-aws
wants to merge
37
commits into
main
Choose a base branch
from
feature-scheduling-strikes-back
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated all tabs to include relative date range & as of date. Added new spend by calendar period visual to allow for quarterly analysis
Co-authored-by: Iakov Gan <[email protected]>
Co-authored-by: Iakov Gan <[email protected]>
* initial for cur-aggregation.yaml * security recommendations for cur-aggregator --------- Co-authored-by: Iakov Gan <[email protected]>
Co-authored-by: Iakov Gan <[email protected]>
Co-authored-by: Sean Nixon <[email protected]>
* added function which creates refresh schedules for new created dataset * Several smaller bugfixes * Set proper log levels * Simplify if conditions * Create schedule when dataset is updated * Added schedules in resources.yaml * Updated resources.yaml with schedules for kpi datasets * Refresh schedule parameters are taken from config or from environment * created function which generates random hh:mm time within provided time range * bugfix when time_to is smaller than time_from, for example '21:00-01:01' * disabling cron for quicksight refresh schedule * removed unused functions. bugfix for default * adjust naming to quicksight structure * replacing regex solution with split function * improves logic when creating refresh dataset * Added schedule for all datasets * Added schedule for all datasets * Changed structure in resources.yaml in a way that for each dataset, schedules are at the same level as dependsOn --------- Co-authored-by: Babic <[email protected]>
…et schedules for datasets
yprikhodko
reviewed
Jul 3, 2023
cid/builtin/core/data/resources.yaml
Outdated
@@ -119,33 +127,45 @@ datasets: | |||
cur: true | |||
views: | |||
- ${cur_table_name} | |||
schedules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schedule on customer_all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.