-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed inconsistency when creating account_map view #487
base: main
Are you sure you want to change the base?
Fixed inconsistency when creating account_map view #487
Conversation
* added missing closing bracket in query in file account_map.sql
@@ -1,10 +1,12 @@ | |||
CREATE OR REPLACE VIEW account_map AS | |||
SELECT | |||
${account_id} AS account_id, | |||
MAX_BY(${account_name}, concat(${account_name}, ': ', ${account_id}) AS account_name | |||
FROM | |||
MAX_BY(${account_name}, concat(${account_name}, ': ', ${account_id})) AS account_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is fixed missing closing bracket. Without fix, dashboard deployment will crash.
This PR seems stale? I ran into this issue when using the |
Hi Please can you provide more info regarding your issue? This PR was not compatible with update procedure so we put it on hold. |
I'm new to CUDOS and QuickSight so I'll try to explain as good as I can :) After running the command (installed latest with pip) on CUDOS v0.2.46 the datasets in QuickSight failed with column errors (account_email_id not found) or STALE (mismatch between number of columns).
I had to manually update all the views in Athena and refresh and publish the datasets in QuickSight to resolve the issue. I also have some NULL values in the dashboard. It seems like there could be some accounts maybe missing, so I will check that first. But I was expecting the behavior for mapping to show account number if no account_name was found. |
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.