Support image files in notebook 1 data prep #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the build_data_manifest utility to support single-page image format documents, for which the pdf2image_regex isn't applicable to look up cleaned images in S3 from input file.
Use IFrame() instead of HTML() to suppress IPython warning. Seems it's unnecessary to specify content_type, although both the old and new solutions worked fine with images as well as PDFs. (Tested in SMStudio on Firefox only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the build_data_manifest utility to support single-page image
format documents, for which the pdf2image_regex isn't applicable to
look up cleaned images in S3 from input file.
Issue #, if available: #5
Description of changes:
Update/fix the
build_data_manifestutility function to support single-page image format documents.Previously, this function assumed the
pdf2image_regexwas applicable to all input documents: But the preprocessing job outputs don't match this format when input raw documents are single images (e.g. PNG, JPEG) or multi-page images (e.g. TIFF). This resulted in errors failing to build collatedtextract-ref+source-refmanifests for custom corpora including non-PDF documents.Testing done:
Initially tested with synthetic corpus - exploring additional tests to verify the fix
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.