Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the CFN templates for the chatbot to use mappings for region #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bechbd
Copy link
Contributor

@bechbd bechbd commented Aug 12, 2024

Fixed the CFN templates for the chatbot to use mappings for region and had to update them to python 3.8 since 3.7 is deprecated

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Content:
S3Bucket:
S3Bucket:
Fn::Join:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using the RegionMap

Content:
S3Bucket:
S3Bucket:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be using the RegionMap

Copy link
Contributor

@iansrobinson iansrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are 2 places in gremlin/chatbot-full-stack-application/cfn-templates/lexbot-deploy.yaml that still need to use the RegionMap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants