New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gov partition and service principal #2

Open

rgzoso wants to merge 2 commits into aws-samples:main from rgzoso:gov_partition_and_service_principal

rgzoso commented Jun 20, 2024

Issue #, if available:

Description of changes:

Use of data lookup for partition so this is usable for gov-cloud
Logic to use a Entra ID (AzureAD) Service Principal short-term token instead of PAT
Updated permission logic to work with ecs task definition revisions
GovCloud CodePipeline requires the project_visibility directive
AWS ECS doesnt honor Dockerfile health check. Updated to work with ECS Task Definition.
terraform.tfvars: ado_org needs to be the Org Name not the ID. Wording was confusing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Reed Gregory added 2 commits

June 20, 2024 13:32


          use partition data

db7192c

add logic for Service Principal instead of PAT


          readme update

a59a662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet