Add OTP (Software MFA Token) Support. #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
I added support for the SOFTWARE_TOKEN_MFA authentication mode for plaintext authentication and SRP authentication. This was specific to our use-case, but I believe it is a helpful addition so I am making an upstream PR.
This is my first contribution to this AWS repository, so please let me know if I need to make additional changes.
The exact changes are as follows:
otpMfaCodeparameter to the authenticateWithPlaintextPassword and authenticateWithSrp functions.SOFTWARE_TOKEN_MFAchallenge.This change was made as part of the ĀYŌDÈ organization.
Testing:
I tested both the plaintext authentication and srp authentication modes with the OTP authentication callback. I also ran
eslintandprettieron the codebase.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.