Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for modifying security headers #74

Merged
merged 2 commits into from
May 17, 2024

Conversation

angelotrivelli
Copy link
Contributor

The code example no longer uses lambda@edge to configure security headers, so this pull request just updates the instructions on how to change the security headers.

Issue #, if available: 73

Description of changes:

  1. Retitle "Updating the site Content Security Policy" to "Updating the site Response Headers"
  2. Update instructions to modify templates/cloudfront-site.yaml instead of source/secured-headers/index.js which no longer exists.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This solution now uses CloudFront Response headers, and these can be edited in the cloudfront-site.yaml template. See issue [73](aws-samples#73
@angelotrivelli angelotrivelli requested a review from a team as a code owner April 21, 2024 17:22
Copy link
Contributor

@ConnorKirk ConnorKirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@ConnorKirk ConnorKirk merged commit 1af0cd2 into aws-samples:master May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants