Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge from aics #472

Merged
merged 6 commits into from
Dec 5, 2024
Merged

chore: merge from aics #472

merged 6 commits into from
Dec 5, 2024

Conversation

NingLu
Copy link
Collaborator

@NingLu NingLu commented Dec 5, 2024

Fixes #

🤖 AI-Generated PR Description (Powered by Amazon Bedrock)

Description

This pull request introduces modifications to the chat infrastructure and language model integration components of the project. The changes aim to enhance the functionality and improve the overall performance of the chat system.

The config.ts file in the source/infrastructure/bin directory has been updated to reflect the latest configuration settings for the chat infrastructure.

The chat-stack.ts file in the source/infrastructure/lib/chat directory has been modified to incorporate improvements to the chat stack management and deployment process.

The types.ts file in the source/infrastructure/lib/shared directory has been updated to include new type definitions and interfaces required for the chat system enhancements.

Additionally, the bedrock_models.py file in the source/lambda/online/common_logic/langchain_integration/chat_models directory has been modified to integrate new language models and optimize their performance within the chat system.

These changes do not introduce any breaking changes or require additional dependencies.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

File Stats Summary

File number involved in this PR: 4, unfold to see the details:

The file changes summary is as follows:

Files
Changes
Change Summary
source/infrastructure/lib/chat/chat-stack.ts 2 added, 0 removed The code changes add environment variables for Bedrock AWS access key ID and secret access key to the Lambda function.
source/infrastructure/lib/shared/types.ts 2 added, 0 removed The code changes add optional properties 'bedrockAk' and 'bedrockSk' to the 'chat' object in the SystemConfig interface.
source/infrastructure/bin/config.ts 2 added, 0 removed The code changes add two new configuration properties, bedrockAk and bedrockSk, for the chat feature, likely related to authentication or access keys.
source/lambda/online/common_logic/langchain_integration/chat_models/bedrock_models.py 27 added, 8 removed This code change adds the ability to use AWS access key and secret access key from environment variables to initialize the ChatBedrockConverse model, instead of relying solely on the credentials profile name.

@NingLu NingLu merged commit 55ab80d into dev Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants