-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics): add warning for invalid dimension values; prevent their addition to EMF blobs #5542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Nov 12, 2024
dreamorosi
reviewed
Nov 12, 2024
aws_lambda_powertools/metrics/provider/cloudwatch_emf/cloudwatch.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5542 +/- ##
========================================
Coverage 96.16% 96.16%
========================================
Files 229 229
Lines 10812 10815 +3
Branches 2008 2009 +1
========================================
+ Hits 10397 10400 +3
Misses 327 327
Partials 88 88 ☔ View full report in Codecov by Sentry. |
boring-cyborg
bot
added
the
documentation
Improvements or additions to documentation
label
Nov 12, 2024
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Nov 12, 2024
dreamorosi
previously approved these changes
Nov 12, 2024
boring-cyborg
bot
added
the
documentation
Improvements or additions to documentation
label
Nov 12, 2024
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Nov 12, 2024
dreamorosi
approved these changes
Nov 12, 2024
boring-cyborg
bot
added
the
documentation
Improvements or additions to documentation
label
Nov 12, 2024
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Nov 12, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #5526
Summary
Changes
Before this PR, if a customer added a dimension with an empty value, it caused EMF to skip all dimensions and create a metric without dimensions. For example:
This pull request enhances the metrics dimension handling by adding a warning for invalid dimension values and preventing these invalid dimensions from being added to the EMF (Enhanced Metric Format) blobs emitted by the utility.
Changes
User experience
Customer will get the following warning:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.