Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layers): rename Lambda layer name from x86 to x86_64 #5226

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Sep 24, 2024

Issue number: #5227

Summary

Updates references of x86 to x86_64 to ensure accuracy

Changes

Please provide a summary of what's being changed

find/replace of x86 with x86_64 to ensure that lambda layers are correctly named.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested a review from a team as a code owner September 24, 2024 13:20
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code internal Maintenance changes labels Sep 24, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2024
@github-actions github-actions bot added bug Something isn't working and removed documentation Improvements or additions to documentation internal Maintenance changes labels Sep 24, 2024
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Sep 24, 2024
@github-actions github-actions bot removed documentation Improvements or additions to documentation internal Maintenance changes labels Sep 24, 2024
@leandrodamascena
Copy link
Contributor

leandrodamascena commented Sep 24, 2024

Hey @sthulb, before we merge this PR, please open a PR to the CDK Layer repository to change the Layer description and include the runtime, as we discussed today morning. After releasing a version we can update the Layer stack to use the new CDK version and approve this PR.

Reference: https://github.com/aws-powertools/powertools-lambda-layer-cdk/blob/next/src/lambda-powertools-layer-python-v3.ts#L79

@leandrodamascena leandrodamascena added the on-hold This item is on-hold and will be revisited in the future label Sep 24, 2024
@leandrodamascena leandrodamascena linked an issue Sep 24, 2024 that may be closed by this pull request
@leandrodamascena leandrodamascena changed the title fix: update singular x86 references to x86_64 fix(layers): rename Lambda layer name from x86 to x86_64 Sep 30, 2024
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Sep 30, 2024
@github-actions github-actions bot removed documentation Improvements or additions to documentation internal Maintenance changes labels Sep 30, 2024
@leandrodamascena
Copy link
Contributor

Hey @sthulb, before we merge this PR, please open a PR to the CDK Layer repository to change the Layer description and include the runtime, as we discussed today morning. After releasing a version we can update the Layer stack to use the new CDK version and approve this PR.

Reference: aws-powertools/powertools-lambda-layer-cdk@next/src/lambda-powertools-layer-python-v3.ts#L79

I have submitted a PR to fix this: aws-powertools/powertools-lambda-layer-cdk#108

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Sep 30, 2024
@github-actions github-actions bot removed documentation Improvements or additions to documentation internal Maintenance changes labels Sep 30, 2024
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Oct 1, 2024
Copy link

sonarcloud bot commented Oct 1, 2024

@github-actions github-actions bot removed documentation Improvements or additions to documentation internal Maintenance changes labels Oct 1, 2024
@leandrodamascena leandrodamascena merged commit 727bac1 into develop Oct 1, 2024
9 checks passed
@leandrodamascena leandrodamascena deleted the bug/x86 branch October 1, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github-actions Pull requests that update Github_actions code on-hold This item is on-hold and will be revisited in the future size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: x86_64 Lambda layers uses the wrong name
2 participants