Update src/sessions/SessionManager.ts

Co-authored-by: Quinn Hanam <[email protected]>
aws-observability · limhjgrace · Jul 8, 2024 · Jun 6, 2024 · Jun 7, 2024 · Jun 10, 2024
commit b97d3c07c221a41d2c46126382e8b66ca99dc910
diff --git a/src/sessions/SessionManager.ts b/src/sessions/SessionManager.ts
@@ -176,11 +176,7 @@
     private createOrRenewSessionCookie(session: Session, expires: Date) {
         if (btoa) {
             storeCookie(
-                getCookieName(
-                    this.config.cookieAttributes.unique,
-                    SESSION_COOKIE_NAME,
-                    this.appMonitorDetails.id!
-                ),
+                this.sessionCookieName,
                 btoa(JSON.stringify(session)),
                 this.config.cookieAttributes,
                 undefined,

diff --git a/src/dispatch/Authentication.ts b/src/dispatch/Authentication.ts
 import { getCookieName } from '../utils/cookies-utils';

 export abstract class Authentication {
    protected applicationId: string;
    protected cognitoIdentityClient: CognitoIdentityClient;
    protected config: Config;
    protected credentials: AwsCredentialIdentity | undefined;
            fetchRequestHandler: new FetchHttpHandler(),
            region
        });
        this.credentialStorageKey = this.config.cookieAttributes.unique
            ? `${CRED_KEY}_${this.applicationId}`
            : CRED_KEY;
    }

                try {
                    credentials = JSON.parse(
                        localStorage.getItem(
                            this.credentialStorageKey
                        )!
                    );
                } catch (e) {
	import { getCookieName } from '../utils/cookies-utils';

	export abstract class Authentication {
	protected applicationId: string;
Check failure on line 9 in src/dispatch/Authentication.ts GitHub Actions / Run Integ Tests on ubuntu-20.04 `Property 'applicationId' has no initializer and is not definitely assigned in the constructor.` Check failure on line 9 in src/dispatch/Authentication.ts GitHub Actions / Run Integ Tests on windows-latest `Property 'applicationId' has no initializer and is not definitely assigned in the constructor.`
	protected cognitoIdentityClient: CognitoIdentityClient;
	protected config: Config;
	protected credentials: AwsCredentialIdentity \| undefined;
	fetchRequestHandler: new FetchHttpHandler(),
	region
	});
	this.credentialStorageKey = this.config.cookieAttributes.unique
Check failure on line 21 in src/dispatch/Authentication.ts GitHub Actions / Run Integ Tests on ubuntu-20.04 `Property 'credentialStorageKey' does not exist on type 'Authentication'.` Check failure on line 21 in src/dispatch/Authentication.ts GitHub Actions / Run Integ Tests on windows-latest `Property 'credentialStorageKey' does not exist on type 'Authentication'.`
	? `${CRED_KEY}_${this.applicationId}`
Check failure on line 22 in src/dispatch/Authentication.ts GitHub Actions / Run Integ Tests on ubuntu-20.04 `Property 'applicationId' is used before being assigned.` Check failure on line 22 in src/dispatch/Authentication.ts GitHub Actions / Run Integ Tests on windows-latest `Property 'applicationId' is used before being assigned.`
	: CRED_KEY;
	}

	try {
	credentials = JSON.parse(
	localStorage.getItem(
	this.credentialStorageKey
Check failure on line 90 in src/dispatch/Authentication.ts GitHub Actions / Run Integ Tests on ubuntu-20.04 `Property 'credentialStorageKey' does not exist on type 'Authentication'.` Check failure on line 90 in src/dispatch/Authentication.ts GitHub Actions / Run Integ Tests on windows-latest `Property 'credentialStorageKey' does not exist on type 'Authentication'.`
	)!
	);
	} catch (e) {