Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Karpenter pattern to use v0.32.1 with v1beta1 APIs #1819

Merged
merged 6 commits into from
Dec 8, 2023
Merged

feat: Update Karpenter pattern to use v0.32.1 with v1beta1 APIs #1819

merged 6 commits into from
Dec 8, 2023

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Update Karpenter pattern to use v0.32.1 with v1beta1 APIs
  • Remove the kubectl provider since it is no longer maintained

Motivation and Context

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner November 1, 2023 21:52
rodrigobersa
rodrigobersa reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This have just 2 manifests, but in other examples where we have more, wouldn't be better to have a manifests directory?

@bryantbiggs
Copy link
Contributor Author

wouldn't be better to have a manifests directory?

I'm curious to know more - how and what would this directory improve?

@rodrigobersa
Copy link
Contributor

wouldn't be better to have a manifests directory?

I'm curious to know more - how and what would this directory improve?

Just can keep the patterns directory more organized, separation of concerns between .tf and .yaml.

tree
.
├── 1.yaml
├── 2.yaml
├── 3.yaml
├── 4.yaml
├── 5.yaml
├── README.md
├── main.tf
├── outputs.tf
├── variables.tf
└── versions.tf

tree
.
├── README.md
├── main.tf
├── manifests
│   ├── 1.yaml
│   ├── 2.yaml
│   ├── 3.yaml
│   ├── 4.yaml
│   └── 5.yaml
├── outputs.tf
├── variables.tf
└── versions.tf

@bryantbiggs
Copy link
Contributor Author

converting to draft until aws-ia/terraform-aws-eks-blueprints-addons#298 is released

@bryantbiggs bryantbiggs marked this pull request as draft November 3, 2023 20:44
@bryantbiggs bryantbiggs mentioned this pull request Nov 4, 2023
Closed
3 tasks
@bryantbiggs bryantbiggs marked this pull request as ready for review November 4, 2023 18:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 5, 2023
allamand
allamand reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@allamand allamand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm creating a cluster to see if it's all working

patterns/karpenter/main.tf
data "aws_ecrpublic_authorization_token" "token" {
provider = aws.virginia
}

data "aws_availability_zones" "available" {}

locals {
name = basename(path.cwd)
name = "ex-${basename(path.cwd)}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why adding ex- ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be certain the resources created are distinguishable and avoid name conflicts - ex-karpenter vs karpenter

askulkarni2
askulkarni2 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

allamand
allamand reviewed Dec 7, 2023
View reviewed changes
patterns/karpenter/README.md Outdated
kubectl apply -f karpenter.yaml
```

3. With the Karpenter resources are in place, when pods are pending in the scheduler's queue, Karpenter will provision the necessary EC2 resources to satisfy those requests. You can demonstrate this with the example deployment provided. First deploy the example deployment which has the initial number replicas set to 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the Karpenter resources are in place -> need rephrase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - updated in 4506824

@github-actions github-actions bot removed the stale label Dec 8, 2023
@bryantbiggs bryantbiggs merged commit aa8222b into main Dec 8, 2023
35 checks passed
@bryantbiggs bryantbiggs deleted the feat/update-karpenter branch December 8, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigobersa rodrigobersa rodrigobersa left review comments

@allamand allamand allamand left review comments

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bryantbiggs @rodrigobersa @askulkarni2 @allamand