feat(cert-manager): GitOps: Add support for installing issuers #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently cert-manager with GitOps config has the two issues: 1. It does not install CA, whereas it is installed by default without GitOps 2. It does not support `cert_manager_install_letsencrypt_issuers` option. To resolve the issue, I did the following: 1. Copy the [helm charts](1) to [eks-blueprints-add-ons](2) as-is. 2. Add additional configuration to support those two helm charts. [1]: https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/kubernetes-addons/cert-manager [2]: https://github.com/aws-samples/eks-blueprints-add-ons
The previous commit uses a complext object type to specify values for
a helm chart with multiple subcharts.
However this triggers Inconsistent conditional result types error like
following:
> Error: Inconsistent conditional result types
> on .terraform/modules/eks.blueprints_kubernetes_addons/modules/kubernetes-addons/argocd/main.tf line 72, in resource "helm_release" "argocd_application":
> 72: each.value.add_on_application ? var.addon_config : {}
> ├────────────────
> │ each.value.add_on_application is true
> │ var.addon_config is object with 10 attributes
>
> The true and false result expressions must have consistent types. The
> 'true' value includes object attribute "awsEfsCsiDriver", which is absent
> in the 'false' value.
To workaround the issue I had to encode & decode the line causing the issue.
It doesn't look pretty but I don't come up a better solution.
kbumsik
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two descriptions for each commits:
feat(cert-manager): GitOps: Add support for installing issuers
Currently cert-manager with GitOps config has the two issues:
cert_manager_install_letsencrypt_issuersoption.To resolve the issue, I did the following:
feat(argocd): handle complex object type for addon_config
The previous commit uses a complext object type to specify values for
a helm chart with multiple subcharts.
However this triggers Inconsistent conditional result types error like
following:
To workaround the issue I had to encode & decode the line causing the issue.
It doesn't look pretty but I don't come up a better solution.
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes