Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: workaround using pkcs1 #121

Merged
merged 1 commit into from
Mar 31, 2023
Merged

chore: workaround using pkcs1 #121

merged 1 commit into from
Mar 31, 2023

Conversation

jcosentino11
Copy link
Member

@jcosentino11 jcosentino11 commented Mar 31, 2023

Issue #, if available:

Description of changes:

Our mqtt5 client currently doesn't work with ssl for windows/mac, due to awslabs/aws-c-io#260. To workaround in the meantime, bridge can encode keys with pkcs1

Why is this change necessary:
Unblock local and windows integration and uat

How was this change tested:

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

Unit Tests Coverage Report

File Coverage Lines Branches
All files 83% 88% 77%
com.aws.greengrass.mqtt.bridge.clients.LocalMqtt5Client$1 92% 100% 83%
com.aws.greengrass.mqtt.bridge.clients.MQTTClient 79% 84% 73%
com.aws.greengrass.mqtt.bridge.clients.MQTTClient$1 70% 90% 50%
com.aws.greengrass.mqtt.bridge.clients.IoTCoreClient 81% 80% 83%
com.aws.greengrass.mqtt.bridge.clients.PubSubClient 85% 94% 75%
com.aws.greengrass.mqtt.bridge.clients.IoTCoreClient$1 100% 100% 0%
com.aws.greengrass.mqtt.bridge.clients.LocalMqttClientFactory 84% 92% 75%
com.aws.greengrass.mqtt.bridge.clients.LocalMqtt5Client 83% 87% 79%
com.aws.greengrass.mqtt.bridge.BridgeConfig 96% 97% 95%
com.aws.greengrass.mqtt.bridge.MQTTBridge 70% 89% 50%
com.aws.greengrass.mqtt.bridge.TopicMapping$TopicType 100% 100% 0%
com.aws.greengrass.mqtt.bridge.MessageBridge 71% 85% 56%
com.aws.greengrass.mqtt.bridge.TopicMapping$MappingEntry 100% 100% 100%
com.aws.greengrass.mqtt.bridge.BridgeConfig$2 100% 100% 0%
com.aws.greengrass.mqtt.bridge.MQTTBridge$ConfigurationChangeHandler 100% 100% 100%
com.aws.greengrass.mqtt.bridge.MQTTBridge$CertificateAuthorityChangeHandler 76% 78% 75%
com.aws.greengrass.mqtt.bridge.BridgeConfig$1 100% 100% 0%
com.aws.greengrass.mqtt.bridge.TopicMapping 100% 100% 100%
com.aws.greengrass.mqtt.bridge.model.MqttVersion 100% 100% 0%
com.aws.greengrass.mqtt.bridge.model.MqttMessage 75% 100% 50%
com.aws.greengrass.mqtt.bridge.model.BridgeConfigReference 100% 100% 0%
com.aws.greengrass.mqtt.bridge.model.PubSubMessage 69% 88% 50%
com.aws.greengrass.mqtt.bridge.auth.MQTTClientKeyStore 89% 90% 88%

Minimum allowed coverage is 65%

Generated by 🐒 cobertura-action against e55f668

@jcosentino11 jcosentino11 merged commit fd4d9fd into main Mar 31, 2023
@jcosentino11 jcosentino11 deleted the pkcs1 branch March 31, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants