fix: replace return in modify-sudoers #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, thank you. Can you please adjust your commit message to comply with conventional commit format? I would suggest "fix: replace return in modify-sudoers" |
Fixed a misplaced 'return' instruction by a more appropriate 'exit' instruction. The 'return' instruction can be used only in a function. Signed-off-by: Adrien Ricciardi <[email protected]>
RICCIARDI-Adrien
force-pushed
the
fix_return_in_modify_sudoers
branch
from
fd98c22
to
3bd2b8a
Compare
MikeDombo
changed the title
MikeDombo
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
Fixed a misplaced
returninstruction by a more appropriateexitinstruction.Why is this change necessary:
The
returninstruction can be used only in a function. The script crashes if thereturninstruction is being executed here because it is called out of a function body.How was this change tested:
Running the script when the
sudoersfile was already updated was crashing the script. With the fix, the script now gracefully exits as expected.Any additional information or context required to review the change:
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.