Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent concurrent result sets for a statement #39

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

jcosentino11
Copy link
Member

Issue #, if available:

Description of changes:
Since moving to cached connections, we've began seeing java.sql.SQLException: ResultSet already requested failures in UATs. This change synchronizes getSpoolMessageById and getAllSpoolMessageIds to ensure there's one result set being operated on for a given statement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

MikeDombo
MikeDombo previously approved these changes Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

Unit Tests Coverage Report

File Coverage Lines Branches
All files 91% 85% 97%
com.aws.greengrass.disk.spool.DiskSpoolDAO$RemoveSpoolMessageById 100% 100% 0%
com.aws.greengrass.disk.spool.DiskSpoolDAO$CachedStatement 94% 88% 100%
com.aws.greengrass.disk.spool.DiskSpoolDAO$GetSpoolMessageById 100% 100% 100%
com.aws.greengrass.disk.spool.DiskSpoolDAO$CreateSpoolerTable 100% 100% 0%
com.aws.greengrass.disk.spool.DiskSpoolDAO 87% 83% 90%
com.aws.greengrass.disk.spool.DiskSpoolDAO$GetSpoolMessageById$1 100% 100% 0%
com.aws.greengrass.disk.spool.DiskSpool 61% 61% 0%
com.aws.greengrass.disk.spool.DiskSpoolDAO$InsertSpoolMessage 97% 94% 100%
com.aws.greengrass.disk.spool.DiskSpoolDAO$GetAllSpoolMessageIds 100% 100% 100%

Minimum allowed coverage is 65%

Generated by 🐒 cobertura-action against c99b808

@jcosentino11 jcosentino11 merged commit 30dc51e into main Dec 4, 2023
2 checks passed
@jcosentino11 jcosentino11 deleted the get-sync branch December 4, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants