Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring back driver registration #37

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

jcosentino11
Copy link
Contributor

@jcosentino11 jcosentino11 commented Nov 14, 2023

Issue #, if available:

Description of changes:
While passing in local unit/integration tests, #36 broke UATs due to driver not being registered.

java.io.IOException: java.sql.SQLException: No suitable driver found for jdbc:sqlite:/home/ec2-user/testResults/23a8fe84c2b77e4bcf9352b2925df0db9fd6d40b/work/aws.greengrass.DiskSpooler/spooler.db

This change brings back registration.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

Unit Tests Coverage Report

File Coverage Lines Branches
All files 91% 85% 97%
com.aws.greengrass.disk.spool.DiskSpoolDAO$RemoveSpoolMessageById 100% 100% 0%
com.aws.greengrass.disk.spool.DiskSpoolDAO$CachedStatement 94% 88% 100%
com.aws.greengrass.disk.spool.DiskSpoolDAO$CreateSpoolerTable 100% 100% 0%
com.aws.greengrass.disk.spool.DiskSpoolDAO$GetSpoolMessageById 100% 100% 100%
com.aws.greengrass.disk.spool.DiskSpoolDAO 87% 83% 90%
com.aws.greengrass.disk.spool.DiskSpoolDAO$GetSpoolMessageById$1 100% 100% 0%
com.aws.greengrass.disk.spool.DiskSpool 61% 61% 0%
com.aws.greengrass.disk.spool.DiskSpoolDAO$InsertSpoolMessage 97% 94% 100%
com.aws.greengrass.disk.spool.DiskSpoolDAO$GetAllSpoolMessageIds 100% 100% 100%

Minimum allowed coverage is 65%

Generated by 🐒 cobertura-action against a40b91b

@jcosentino11 jcosentino11 merged commit b380f8d into main Nov 14, 2023
2 checks passed
@jcosentino11 jcosentino11 deleted the driver-registration branch November 14, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants