Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated package name #80

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Updated package name #80

merged 3 commits into from
Jul 30, 2024

Conversation

cgalvan
Copy link
Collaborator

@cgalvan cgalvan commented Jul 29, 2024 •
edited
Loading

Description

Updated official package name from Amazon Location Migration Adapter to Amazon Location Migration SDK.

@cgalvan cgalvan requested a review from a team as a code owner July 29, 2024 19:57
ejboucher
ejboucher previously approved these changes Jul 29, 2024
View reviewed changes
jonayuan
jonayuan previously approved these changes Jul 29, 2024
View reviewed changes
@cgalvan cgalvan requested a review from jonayuan July 29, 2024 22:03
@cgalvan cgalvan dismissed stale reviews from jonayuan and ejboucher via 5b2b4e9 July 30, 2024 16:22
@cgalvan cgalvan requested a review from ejboucher July 30, 2024 16:22
jonayuan
jonayuan reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@jonayuan jonayuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we kept the repo URL as amazon-location-migration rather than amazon-location-migration-sdk?

@cgalvan
Copy link
Collaborator Author

cgalvan commented Jul 30, 2024

Is there a reason we kept the repo URL as amazon-location-migration rather than amazon-location-migration-sdk?

Yes, the project's high-level name is still "Amazon Location Migration" but this particular package is the SDK

@cgalvan cgalvan merged commit 4ea33d6 into aws-geospatial:main Jul 30, 2024
1 check passed
@cgalvan cgalvan deleted the UpdatedPackageName branch July 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonayuan jonayuan jonayuan approved these changes

@ejboucher ejboucher ejboucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgalvan @ejboucher @jonayuan