Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed getQueryPredictions implementation #45

Merged
merged 3 commits into from
May 16, 2024
Merged

Completed getQueryPredictions implementation #45

merged 3 commits into from
May 16, 2024

Conversation

cgalvan
Copy link
Collaborator

@cgalvan cgalvan commented May 16, 2024

Description

Completed the getQueryPredictions implementation to handle all that we currently can support.

  • Added handling for bounds input
  • Added unit tests that give full coverage to the places module now

Testing

Verified unit tests all pass, and now places module is 100% covered, since the getQueryPredictions API was the last remaining prototype implementation that didn't have unit tests yet.

------------------|---------|----------|---------|---------|--------------------------
File              | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------|---------|----------|---------|---------|--------------------------
All files         |   88.07 |    89.23 |   86.79 |   88.14 |
 directions.ts    |    9.25 |        0 |       0 |    7.69 | 26-204
 google.maps.d.ts |       0 |        0 |       0 |       0 |
 googleCommon.ts  |     100 |      100 |     100 |     100 |
 index.ts         |     100 |      100 |     100 |     100 |
 infoWindow.ts    |     100 |      100 |     100 |     100 |
 maps.ts          |     100 |    97.26 |     100 |     100 | 105
 markers.ts       |   78.66 |    66.66 |      90 |   78.66 | 63-68,88-115,140,310-334
 places.ts        |     100 |      100 |     100 |     100 |
------------------|---------|----------|---------|---------|--------------------------

Test Suites: 6 passed, 6 total
Tests:       122 passed, 122 total

Also built/ran the examples and verified they still work as expected.

@cgalvan cgalvan requested a review from a team as a code owner May 16, 2024 15:35
@cgalvan cgalvan merged commit 89499d3 into aws-geospatial:main May 16, 2024
1 check passed
@cgalvan cgalvan deleted the CompletedGetQueryPredictions branch May 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants