fix: add deadline cloud soho script #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucaseck <[email protected]>
|
miabatta
approved these changes
Nov 1, 2024
leongdl
approved these changes
Nov 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #168
What was the problem/requirement? (What/Why)
When the render button was clicked on the Deadline Cloud node the user would get a notification that no soho script was found.
What was the solution? (How)
Add a soho script and set it up to be run when the render button is clicked on the Deadline Cloud node. The script will display a message to the user that to render with the Deadline Cloud node they should click the submit button within the node instead of clicking render on it.
What is the impact of this change?
Hopefully less confusion on how to render with the Deadline Cloud node.
How was this change tested?
Made an empty scene with just a Deadline Cloud node and clicked render to verify that the "no soho script" error would show. Then made my changes and verified a new popup appeared that pointed me towards pressing the submit button in the node itself.
Yes
Was this change documented?
It will be documented as closing issue 168
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.