Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.43.0, code-generator v0.43.1 #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Feb 19, 2025

Update to ACK runtime v0.43.0, code-generator v0.43.1



NOTE:
This PR increments the release version of service controller from v1.0.3 to v1.0.4

Once this PR is merged, release v1.0.4 will be automatically created for ssm-controller

Please close this PR, if you do not want the new patch release for ssm-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building ssm-controller ====
Copying common custom resource definitions into ssm
Building Kubernetes API objects for ssm
Generating deepcopy code for ssm
Generating custom resource definitions for ssm
Building service controller for ssm
Running GO mod tidy
Generating RBAC manifests for ssm
Running gofmt against generated code for ssm
Updating additional GitHub repository maintenance files
==== building ssm-controller release artifacts ====
Building release artifacts for ssm-v1.0.4
Generating common custom resource definitions
Generating custom resource definitions for ssm
Generating RBAC manifests for ssm

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Feb 19, 2025
@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm February 19, 2025 23:02
Copy link

ack-prow bot commented Feb 19, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ssm-verify-attribution 7256c0f link false /test ssm-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91
Copy link
Member

/lgtm

Copy link

ack-prow bot commented Feb 19, 2025

@rushmash91: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ack-prow bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot, rushmash91
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants