Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.28.0, code-generator v0.28.0 #67

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Dec 14, 2023

Update to ACK runtime v0.28.0, code-generator v0.28.0



NOTE:
This PR increments the release version of service controller from v0.0.28 to v0.0.29

Once this PR is merged, release v0.0.29 will be automatically created for mq-controller

Please close this PR, if you do not want the new patch release for mq-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building mq-controller ====
Copying common custom resource definitions into mq
Building Kubernetes API objects for mq
Generating deepcopy code for mq
Generating custom resource definitions for mq
Building service controller for mq
Generating RBAC manifests for mq
Running gofmt against generated code for mq
Updating additional GitHub repository maintenance files
==== building mq-controller release artifacts ====
Building release artifacts for mq-v0.0.29
Generating common custom resource definitions
Generating custom resource definitions for mq
Generating RBAC manifests for mq

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and vijtrip2 December 14, 2023 22:27
@a-hilaly a-hilaly force-pushed the ack-bot/rt-v0.28.0-codegen-v0.28.0 branch from ee6c68a to 04c5ce5 Compare December 22, 2023 00:46
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Dec 22, 2023
@a-hilaly a-hilaly force-pushed the ack-bot/rt-v0.28.0-codegen-v0.28.0 branch from 04c5ce5 to d63483b Compare December 22, 2023 01:01
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
@a-hilaly a-hilaly force-pushed the ack-bot/rt-v0.28.0-codegen-v0.28.0 branch from 5ade364 to 7e04370 Compare December 22, 2023 22:53
@a-hilaly a-hilaly force-pushed the ack-bot/rt-v0.28.0-codegen-v0.28.0 branch from 7e04370 to 110e336 Compare December 23, 2023 02:31
@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2023
Copy link

ack-prow bot commented Dec 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit f63f9e3 into main Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants