Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem when original exception message was lost. #350

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wesolowskim
Copy link

@wesolowskim wesolowskim commented Feb 11, 2021

*Issue #351 *
When the exception was thrown with operation name the original errorMessage was lost.
For example

 throw new CfnGeneralServiceException("Operation", new RuntimeException("something happend");

results in "Error occurred during operation 'Operation'." message.
If operation parameter would not be passed then the message would contain "something happend".

Description of changes:
I changed how Exceptions are constructed so behavior is consistent. If "operation" is passed in the original message is preserved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammokhov ammokhov added the enhancement New feature or request label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants