Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose previous and current resource properties #185

Closed
wants to merge 3 commits into from
Closed

Expose previous and current resource properties #185

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47f97f6
Expose previous and current resource properties bytes on request
parsnips Dec 11, 2020
cbeadf2
failing test
parsnips Dec 11, 2020
d9c9ac6
Remove the `Get`
parsnips Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cfn/handler/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ type Request struct {
resourcePropertiesBody []byte
}

func (r *Request) GetPreviousResourcePropertiesBody() []byte {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for using the GetPreviousResourcePropertiesBody instead of just going with PreviousResourcePropertiesBody?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JVM has affected me more than I realized ;). I'll push up the shorter version.

return r.previousResourcePropertiesBody
}

func (r *Request) GetResourcePropertiesBody() []byte {
return r.resourcePropertiesBody
}

// RequestContext represents information about the current
// invocation request of the handler.
type RequestContext struct {
Expand Down