Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch event rule requiredXor to requiredOr #3688

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 13, 2024

Issue #, if available:
fix #3687
Description of changes:

  • Switch event rule requiredXor to requiredOr

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (7b0ad97) to head (3ef1749).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3688      +/-   ##
==========================================
- Coverage   93.67%   93.67%   -0.01%     
==========================================
  Files         358      359       +1     
  Lines       12248    12262      +14     
  Branches     2627     2629       +2     
==========================================
+ Hits        11473    11486      +13     
  Misses        429      429              
- Partials      346      347       +1     
Flag Coverage Δ
unittests 93.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 492b12a into aws-cloudformation:main Sep 13, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3687 branch September 13, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::Events::Rule should allow both ['EventPattern', 'ScheduleExpression'] and should not throw an E3014
1 participant