Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with E3044 #3670

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 6, 2024

Issue #, if available:

Description of changes:

  • Fix an issue with E3044 and EXTERNAL LaunchType with a SchedulingStrategy of DAEMON

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (05be958) to head (c47375d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3670      +/-   ##
==========================================
- Coverage   93.62%   93.61%   -0.02%     
==========================================
  Files         357      357              
  Lines       12193    12189       -4     
  Branches     2616     2616              
==========================================
- Hits        11416    11411       -5     
  Misses        431      431              
- Partials      346      347       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 3b47042 into aws-cloudformation:main Sep 6, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/D121 branch September 6, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant