Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule E3674 to validate instance PrivateIpAddress #3657

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 4, 2024

Issue #, if available:

Description of changes:

  • Add rule E3674 to validate instance PrivateIpAddress

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (31d4036) to head (74d0a41).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
- Coverage   93.73%   93.71%   -0.02%     
==========================================
  Files         356      357       +1     
  Lines       12143    12157      +14     
  Branches     2607     2607              
==========================================
+ Hits        11382    11393      +11     
- Misses        418      419       +1     
- Partials      343      345       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit ad55796 into aws-cloudformation:main Sep 6, 2024
21 of 22 checks passed
@kddejong kddejong deleted the feature/rule/e3674 branch September 6, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant