Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for patch in place #3649

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 3, 2024

Issue #, if available:

Description of changes:

  • Allow for patch in place

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 93.72%. Comparing base (466004b) to head (62283bc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cfnlint/schema/manager.py 73.91% 6 Missing ⚠️
src/cfnlint/runner.py 0.00% 2 Missing and 1 partial ⚠️
src/cfnlint/maintenance.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
- Coverage   93.78%   93.72%   -0.07%     
==========================================
  Files         356      356              
  Lines       12121    12143      +22     
  Branches     2600     2607       +7     
==========================================
+ Hits        11368    11381      +13     
- Misses        411      418       +7     
- Partials      342      344       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit e6eb757 into aws-cloudformation:main Sep 4, 2024
3 checks passed
@kddejong kddejong deleted the feature/patchinplace branch September 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant