Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 - cleaning up more rules #2670

Merged
merged 2 commits into from
Apr 7, 2023
Merged

V1 - cleaning up more rules #2670

merged 2 commits into from
Apr 7, 2023

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Apr 7, 2023 •
edited
Loading

Issue #, if available:
#2606

Description of changes:

  • Bring back logic for W2031
  • Bring back logic for checking Conditions for resource type in a region validation (E3001)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the v1-rules/more/additions branch 2 times, most recently from 603e397 to 5aa9192 Compare April 7, 2023 17:41
@kddejong kddejong merged commit 5b652a3 into aws-cloudformation:v1 Apr 7, 2023
@kddejong kddejong deleted the v1-rules/more/additions branch April 7, 2023 17:54
kddejong added a commit that referenced this pull request Apr 10, 2023
@kddejong
V1 - cleaning up more rules (#2670)
5011f14 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 17, 2023
@kddejong
V1 - cleaning up more rules (#2670)
236df71 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 17, 2023
@kddejong
V1 - cleaning up more rules (#2670)
bdd34b9 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 18, 2023
@kddejong
V1 - cleaning up more rules (#2670)
bb7039c 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 19, 2023
@kddejong
V1 - cleaning up more rules (#2670)
5a01bec 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 25, 2023
@kddejong
V1 - cleaning up more rules (#2670)
af4e35c 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 28, 2023
@kddejong
V1 - cleaning up more rules (#2670)
e1d0c15 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request May 7, 2023
@kddejong
V1 - cleaning up more rules (#2670)
2df4c89 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Jun 13, 2023
@kddejong
V1 - cleaning up more rules (#2670)
36f81c3 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Jun 16, 2023
@kddejong
V1 - cleaning up more rules (#2670)
04ad0f4 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Jul 3, 2023
@kddejong
V1 - cleaning up more rules (#2670)
4e5d30b 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Nov 1, 2023
@kddejong
V1 - cleaning up more rules (aws-cloudformation#2670)
61ac971 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Nov 1, 2023
@kddejong
V1 - cleaning up more rules (#2670)
86ef808 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Nov 1, 2023
@kddejong
V1 - cleaning up more rules (aws-cloudformation#2670)
7ce96a8 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Nov 13, 2023
@kddejong
V1 - cleaning up more rules (#2670)
f22f9e1 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Nov 15, 2023
@kddejong
V1 - cleaning up more rules (#2670)
3a61bb1 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Dec 5, 2023
@kddejong
V1 - cleaning up more rules (#2670)
05908cf 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Dec 7, 2023
@kddejong
V1 - cleaning up more rules (#2670)
b95b137 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Dec 8, 2023
@kddejong
V1 - cleaning up more rules (#2670)
6ad30d4 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Dec 15, 2023
@kddejong
V1 - cleaning up more rules (#2670)
24cc192 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Dec 22, 2023
@kddejong
V1 - cleaning up more rules (#2670)
f282a6b 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Jan 2, 2024
@kddejong
V1 - cleaning up more rules (#2670)
8f9d922 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Jan 11, 2024
@kddejong
V1 - cleaning up more rules (aws-cloudformation#2670)
fc70505 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Jan 17, 2024
@kddejong
V1 - cleaning up more rules (#2670)
1cb0718 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Jan 23, 2024
@kddejong
V1 - cleaning up more rules (#2670)
54035cd 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 5, 2024
@kddejong
V1 - cleaning up more rules (aws-cloudformation#2670)
ed617e9 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Feb 5, 2024
@kddejong
V1 - cleaning up more rules (#2670)
3abc7a6 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 5, 2024
@kddejong
V1 - cleaning up more rules (aws-cloudformation#2670)
4ff4b0f 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 7, 2024
@kddejong
V1 - cleaning up more rules (aws-cloudformation#2670)
ac546e6 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 7, 2024
@kddejong
V1 - cleaning up more rules (aws-cloudformation#2670)
f7953e8 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Feb 16, 2024
@kddejong
V1 - cleaning up more rules (#2670)
fb6b4e4 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Feb 16, 2024
@kddejong
V1 - cleaning up more rules (#2670)
412b530 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Feb 27, 2024
@kddejong
V1 - cleaning up more rules (#2670)
d993a60 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Mar 4, 2024
@kddejong
V1 - cleaning up more rules (#2670)
84c7225 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Mar 12, 2024
@kddejong
V1 - cleaning up more rules (#2670)
4213268 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Apr 4, 2024
@kddejong
V1 - cleaning up more rules (aws-cloudformation#2670)
b17e07e 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 5, 2024
@kddejong
V1 - cleaning up more rules (#2670)
78245ad 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 15, 2024
@kddejong
V1 - cleaning up more rules (#2670)
5c553f0 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 18, 2024
@kddejong
V1 - cleaning up more rules (#2670)
bbb1a26 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 25, 2024
@kddejong
V1 - cleaning up more rules (#2670)
9aee7e9 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request Apr 26, 2024
@kddejong
V1 - cleaning up more rules (#2670)
6d1bb73 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request May 2, 2024
@kddejong
V1 - cleaning up more rules (#2670)
21dc8c5 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
kddejong added a commit that referenced this pull request May 3, 2024
@kddejong
V1 - cleaning up more rules (#2670)
511bda4 
* Add back in logic for rule W2031
* Validate conditions when checking resource types for a region
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kddejong