Skip to content

Commit

Permalink
Cleanup some code
Browse files Browse the repository at this point in the history
  • Loading branch information
kddejong committed Sep 12, 2024
1 parent cd14bd9 commit f6b0ca6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
10 changes: 7 additions & 3 deletions src/cfnlint/context/context.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,13 +289,15 @@ class Parameter(_Ref):
allowed_values: Any = field(init=False)
description: str | None = field(init=False)
ssm_path: str | None = field(init=False, default=None)
is_ssm_parameter: bool = field(init=False, default=False)

parameter: InitVar[Any]

def __post_init__(self, parameter) -> None:
if not isinstance(parameter, dict):
raise ValueError("Parameter must be a object")

self.is_ssm_parameter = lru_cache()(self.is_ssm_parameter) # type: ignore

self.default = None
self.allowed_values = []
self.min_value = None
Expand All @@ -311,8 +313,7 @@ def __post_init__(self, parameter) -> None:

# SSM Parameter defaults and allowed values point to
# SSM paths not to the actual values
if self.type.startswith("AWS::SSM::Parameter::"):
self.is_ssm_parameter = True
if self.is_ssm_parameter():
self.ssm_path = parameter.get("Default", "")
return

Expand Down Expand Up @@ -359,6 +360,9 @@ def ref(self, context: Context) -> Iterator[Tuple[Any, deque]]:
if self.max_value is not None:
yield str(self.max_value), deque(["MaxValue"])

def is_ssm_parameter(self) -> bool:
return self.type.startswith("AWS::SSM::Parameter::")


@dataclass
class Resource(_Ref):
Expand Down
2 changes: 1 addition & 1 deletion src/cfnlint/rules/resources/properties/Pattern.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def pattern(
# https://github.com/aws-cloudformation/cfn-lint/issues/3640
if validator.context.transforms.has_sam_transform():
for _, param in validator.context.parameters.items():
if param.is_ssm_parameter:
if param.is_ssm_parameter():
if param.ssm_path == instance:
return

Expand Down

0 comments on commit f6b0ca6

Please sign in to comment.