Cover network interface PrivateIpAddress

aws-cloudformation · Sep 6, 2024 · af295c6 · af295c6
1 parent ad55796
commit af295c6
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 1 deletion.
diff --git a/src/cfnlint/data/schemas/extensions/aws_ec2_instance/privateipaddress.json b/src/cfnlint/data/schemas/extensions/aws_ec2_instance/privateipaddress.json
@@ -20,7 +20,8 @@
         }
        },
        "type": "array"
-      }
+      },
+      "PrivateIpAddress": false
      }
     },
     "type": "array"

diff --git a/test/unit/rules/resources/ec2/test_private_ip_with_network_interafce.py b/test/unit/rules/resources/ec2/test_private_ip_with_network_interafce.py
@@ -68,6 +68,38 @@ def rule():
             },
             [],
         ),
+        (
+            "Invalid with a private ip address in two spots",
+            {
+                "PrivateIpAddress": "172.31.35.42",
+                "NetworkInterfaces": [
+                    {
+                        "PrivateIpAddress": "172.31.35.42",
+                    }
+                ],
+            },
+            {
+                "path": ["Resources", "Instance", "Properties"],
+            },
+            [
+                ValidationError(
+                    "'Primary' cannot be True when 'PrivateIpAddress' is specified",
+                    validator=None,
+                    rule=PrivateIpWithNetworkInterface(),
+                    path=deque(["NetworkInterfaces", 0, "PrivateIpAddress"]),
+                    schema_path=deque(
+                        [
+                            "then",
+                            "properties",
+                            "NetworkInterfaces",
+                            "items",
+                            "properties",
+                            "PrivateIpAddress",
+                        ]
+                    ),
+                )
+            ],
+        ),
         (
             "Invalid with a private ip address",
             {