Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFN-564(DBClusterParameterGroup) - Fix DBClusterParameterGroup not resetting parameters #588

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

angusy29
Copy link
Contributor

@angusy29 angusy29 commented Jan 8, 2025

Description of changes:

DBClusterParameterGroup was not correctly resetting parameters.

The bug:

Eg. Try creating a DBClusterParameterGroup with:

        require_secure_transport: "ON"
        lower_case_table_names: "1"
        collation_server: "utf8_bin"
        time_zone: "US/Eastern"
        character_set_server: "utf8"
        server_audit_events: "CONNECT,QUERY"
        server_audit_logging: "1"

Then performing an update with:

        lower_case_table_names: "1"
        collation_server: "utf8_bin"
        time_zone: "US/Eastern"
        character_set_server: "utf8"
        server_audit_events: "CONNECT,QUERY"
        server_audit_logging: "1"

The parameter require_secure_transport does not get reset to its default value.

DBParameterGroup however, does exhibit the correct reset behaviour and resets the parameter if it is removed.

This CR ensures the DBClusterParameterGroup behaves like the DBParameterGroup resource when removing parameters.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@angusy29 angusy29 added this pull request to the merge queue Jan 12, 2025
Merged via the queue into aws-cloudformation:master with commit 0fda1ef Jan 12, 2025
1 check passed
@angusy29 angusy29 deleted the reset-param-fix branch January 12, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants