fix: remove defaults on backtrackwindow #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrfr
reviewed
Jun 12, 2024
zrfr
force-pushed
the
fix/rds-cluster-backtrackwindow-defaults
branch
from
85e48bb to
f976515
Compare
zrfr
approved these changes
Jun 12, 2024
|
I've modified the PR to remove only the default (and not the minimum). |
Merged
via the queue into
aws-cloudformation:master
with commit Jun 18, 2024
6ccbf69
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Original issue : hashicorp/terraform-provider-awscc#1805
Description of changes:
The change here is to ensure that the default value of
BacktrackWindowis removed so that the schema referenced by entities like AWSCC provider from Terraform do not send this for every DB engine. Opening this based on the internal ticket opened with the team and their suggestions.The default behaviour - if BacktrackWindow is missing/null - is for backtrack to be disabled.
Setting BacktrackWindow to 0 also disables backtrack.
BacktrackWindow can only be specified if the engine version supports the backtrack feature, otherwise you get the "Backtrack is not enabled" error.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.