[DBInstance] Send both CACertificateIdentifier and CertificateRotationRestart only when the identifier changes #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrfr
reviewed
May 30, 2024
aws-rds-dbinstance/src/main/java/software/amazon/rds/dbinstance/Translator.java
Outdated
Show resolved
Hide resolved
angusy29
force-pushed
the
ca-certificate-identifier
branch
from
5855d98 to
218b653
Compare
angusy29
changed the title
zrfr
reviewed
Jun 4, 2024
aws-rds-dbinstance/src/main/java/software/amazon/rds/dbinstance/Translator.java
Outdated
Show resolved
Hide resolved
zrfr
previously approved these changes
Jun 4, 2024
angusy29
force-pushed
the
ca-certificate-identifier
branch
2 times, most recently
from
8094418 to
5f2972c
Compare
angusy29
changed the title
angusy29
force-pushed
the
ca-certificate-identifier
branch
2 times, most recently
from
5f2972c to
c50d642
Compare
…nRestart only when the identifier changes
zrfr
force-pushed
the
ca-certificate-identifier
branch
from
c50d642 to
8050761
Compare
zrfr
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws-cloudformation/cloudformation-coverage-roadmap#1742
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.