[Common][All] remove silent failure mechanism and throw unauthorized tagging exception #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tagging exception.
moataz-mhmd
force-pushed
the
apply-unauthorized-tagging-exception-on-stack-tags-v2
branch
from
43ac12b to
72bd7ac
Compare
dbbh
approved these changes
Nov 13, 2023
dbbh
pushed a commit
to dbbh/aws-cloudformation-resource-providers-rds
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
To ensure compatibility with older versions, we previously ignored the AccessDenied exception when a customer did not have permission to add stack level tags. This PR addresses this issue by aligning with the latest CloudFormation guidelines and instead throwing an UnauthorizedTaggingOperation error code.
However, we have retained the already exist tagging logic to differentiate between access denied for resource tags and access denied for stack level tags. Once CloudFormation confirms that it is safe to convert UnauthorizedTaggingOperation to the regular AccessDenied error code, we can safely remove all the logic related to tag error management and the safeCreate mechanism.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.