[DBInstance] Ignore terminal domain on delete #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moataz-mhmd
reviewed
Oct 31, 2023
aws-rds-dbinstance/src/main/java/software/amazon/rds/dbinstance/BaseHandlerStd.java
Show resolved
Hide resolved
moataz-mhmd
approved these changes
Nov 2, 2023
angusy29
pushed a commit
to angusy29/aws-cloudformation-resource-providers-rds
that referenced
this pull request
Nov 6, 2024
Co-authored-by: Diogo Henriques <[email protected]> Co-authored-by: Valentin Shirshov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change moves the terminal state check in the DBInstance handler for RDS resources into a separate helper method. Creates and modifies continue to assert terminal status on all resources while delete requests are now only checking for RDS resources. This means terminal domains will no longer impact delete workflows.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.