Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CustomDbEngineVersion] Add new parameters in CEV #477

Closed

Conversation

0ooopsFibby
Copy link

Issue #, if available: N / A

Description of changes:

Latest AWS RDS SDK has added three optional parameters for CEV model and originally required field is now no longer compulsory. This PR is to add the additional parameters to CFN accordingly.

  • unit tests doesn't require changes as it was generated based on model
  • contract tests have passed locally
curl -XPOST "http://localhost:9000/2015-03-31/functions/function/invocations" -d '{ "TypeName": "AWS::RDS::CustomDBEngineVersion", "Bucket": "jiayuwa-cfn", "Key": "aws-service-resource-cev.zip", "TestDetails":["TestCreate,test_create_list", "TestCreate,test_create_create", "TestRead,test_governance", "TestRead,test_read_return_write_only_properties", "TestRead,test_read_return_readonly_properties", "TestDelete,test_delete_read", "TestDelete,test_delete_delete", "TestDelete,test_delete_list", "TestUpdate,test_update_read", "TestUpdate,test_update_list", "TestRead,test_read_return_all_schema_properties_using_one_or_more_inputs"] }' 

test_read_input_output_negative_match from contract test doesn't apply for the API, this is because some parameters are not supposed to be used together (e.g. S3 bucket and source CEV)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant