[All] Fix tagging when stack and resource level tags have jey collisions #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khebul
changed the title
dbbh
previously approved these changes
Oct 9, 2023
dbbh
approved these changes
Oct 9, 2023
dbbh
pushed a commit
to dbbh/aws-cloudformation-resource-providers-rds
that referenced
this pull request
Nov 20, 2023
…ons (aws-cloudformation#470) * [All] Make sure that stack level tags do not override resource level tags --------- Co-authored-by: Valentin Shirshov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that Resource level tags always take precedence over stack level tags. If there is a collision between stack and resource level tags, previously erroneous AddTagsToResource or RemoveTagsFromResource requests could be sent. This PR addresses this issue.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.